thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sokac <...@git.apache.org>
Subject [GitHub] thrift pull request #1401: THRIFT-4373: Derefer PHP zval _TSPEC
Date Thu, 26 Oct 2017 23:46:30 GMT
Github user sokac commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1401#discussion_r147295690
  
    --- Diff: lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp ---
    @@ -709,6 +715,9 @@ void binary_serialize(int8_t thrift_typeID, PHPOutputTransport&
transport, zval*
             throw_tprotocolexception("Attempt to send non-object type as a T_STRUCT", INVALID_DATA);
           }
           zval* spec = zend_read_static_property(Z_OBJCE_P(value), "_TSPEC", sizeof("_TSPEC")-1,
true);
    +      if (spec) {
    --- End diff --
    
    removed if statement


---

Mime
View raw message