thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From RobberPhex <...@git.apache.org>
Subject [GitHub] thrift pull request #1399: THRIFT-4370: build generated code before running ...
Date Thu, 26 Oct 2017 05:38:03 GMT
Github user RobberPhex commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1399#discussion_r147048687
  
    --- Diff: lib/py/setup.py ---
    @@ -22,7 +22,7 @@
     import sys
     try:
         from setuptools import setup, Extension
    -except:
    +except Exception:
    --- End diff --
    
    I think we should use distutils.core, and setuptools is feedback,
    And we should only process ImportError.
    ```py
    try:
         from distutils.core import setup, Extension
    except ImportError:
        from setuptools import setup, Extension
    ```


---

Mime
View raw message