Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 52B8A200D03 for ; Sat, 9 Sep 2017 14:50:48 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 514B61609C4; Sat, 9 Sep 2017 12:50:48 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 96F521609B5 for ; Sat, 9 Sep 2017 14:50:47 +0200 (CEST) Received: (qmail 91280 invoked by uid 500); 9 Sep 2017 12:50:46 -0000 Mailing-List: contact dev-help@thrift.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@thrift.apache.org Delivered-To: mailing list dev@thrift.apache.org Received: (qmail 91268 invoked by uid 99); 9 Sep 2017 12:50:45 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 09 Sep 2017 12:50:45 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 1A2BAE361C; Sat, 9 Sep 2017 12:50:44 +0000 (UTC) From: jeking3 To: dev@thrift.apache.org Reply-To: dev@thrift.apache.org Message-ID: Subject: [GitHub] thrift pull request #1350: Thrift 4325 - simplifying compiler location and e... Content-Type: text/plain Date: Sat, 9 Sep 2017 12:50:44 +0000 (UTC) archived-at: Sat, 09 Sep 2017 12:50:48 -0000 GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1350 Thrift 4325 - simplifying compiler location and enabling cross-compilation This is the application of #1336 merged into master - the original PR from @tpetazzoni was a little stale so I fixed the conflicts and wanted to run it through CI again before committing it. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift THRIFT-4325 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1350.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1350 ---- commit e87142cc64e5a3f2c827300e1ea45c9ae3997aa4 Author: Thomas Petazzoni Date: 2017-08-25T22:10:40Z configure.ac, Makefile.am: introduce THRIFT variable to support cross-compilation The thrift build system currently assumes that the thrift compiler is always available in $(top_builddir)/compiler/cpp/thrift. However, in a cross-compilation context, this location contains the thrift compiler built for the target... which obviously will not run on the build machine. In order to support such cross-compilation situation, we introduce the THRIFT variable as a an argument for the configure script (using AC_ARG_VAR). If not specified, it defaults to the existing value of using compiler/cpp/thrift from the build directory, but it can be overridden when calling ./configure. Note that $(top_builddir) cannot be used within the configure script, so we simply use `pwd`, which is the same as the top_builddir. Signed-off-by: Thomas Petazzoni commit 6388844159ea199f59cb24bda23e4aa615688615 Author: James E. King, III Date: 2017-09-09T04:26:16Z Merge branch 'cross-compilation-support' of https://github.com/tpetazzoni/thrift into THRIFT-4325 ---- ---