Mailing-List: contact dev-help@thrift.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@thrift.apache.org
Date: Sat, 30 Sep 2017 04:41:01 +0000 (UTC)
From: "Christopher Tubbs (JIRA)" <jira@apache.org>
To: dev@thrift.apache.org
Message-ID: <JIRA.13055716.1489438168000.244055.1506746461995@Atlassian.JIRA>
In-Reply-To: <JIRA.13055716.1489438168000@Atlassian.JIRA>
References: <JIRA.13055716.1489438168000@Atlassian.JIRA> <JIRA.13055716.1489438168580@jira-lw-us.apache.org>
Subject: [jira] [Comment Edited] (THRIFT-4119) bootstrap.sh is missing from
 the source tarball
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sat, 30 Sep 2017 04:41:10 -0000


    [ https://issues.apache.org/jira/browse/THRIFT-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16186892#comment-16186892 ] 

Christopher Tubbs edited comment on THRIFT-4119 at 9/30/17 4:40 AM:
--------------------------------------------------------------------

[~Robert Lu], the bug is with the official releases, which are on the Apache mirrors. What you're downloading from GitHub is a generated-on-the-fly snapshot of the source repository at a point in time. That's not the official ASF release.

The problem being reported here is a problem with the build/release process, which does not properly include all the necessary source files to build from source, in the official ASF release artifact. Some of those source files are left behind in the git repository, but excluded from the official release, which is not good enough. Users must be able to build from source using the official releases. This is ASF policy, and why this issue is marked critical.

Providing only `configure` in the official release artifact is not good enough, if something has to be patched downstream for integration (which it does, in the case of the Fedora packaging, to tweak the compiler flags to conform to Fedora's conventions for shared libraries, and probably others).

Additionally, generated code, such as the `configure` script, does not meet the FSF definition of "Free Software" (except in conjunction with the source repository, which is not "released" according to ASF), and does not meet the OSI definition of "Open Source" (considered an "intermediate" form of source, and not the real "source code"). While these definitions do not dictate ASF policies, they are helpful in understanding why the full source should be included in the official release... and not just the intermediate "configure" script.

If you want to include only the "configure" script in a convenience binary, that's fine, but I think the official ASF release artifact should contain *all* the source.


was (Author: ctubbsii):
[~Robert Lu], the bug is with the official releases, which are on the Apache mirrors. What you're downloading from GitHub is a generated-on-the-fly snapshot of the source repository at a point in time. That's not the official ASF release.

The problem being reported here is a problem with the build/release process, which does not properly include all the necessary source files to build from source, in the official ASF release artifact. Some of those source files are left behind in the git repository, but excluded from the official release, which is not good enough. Users must be able to build from source using the official releases. This is ASF policy, and why this issue is marked critical.

Providing only `configure` in the official release artifact is not good enough, if something has to be patched downstream for integration (which it does, in the case of the Fedora packaging, to tweak the compiler flags to conform to Fedora's conventions for shared libraries, and probably others).

Additionally, generated code, such as the `configure` script, does not meet the FSF definition of "Free Software" (except in conjunction with the source repository, which is not "released" according to ASF), and does not meet the OSI definition of "Open Source" (considered an "intermediate" form of source, and not the real "source code"). While these definitions do not dictate ASF policies, they are helpful in understanding why the full source should be included in the official release... and not just the intermediate "configure" script.


> bootstrap.sh is missing from the source tarball
> -----------------------------------------------
>
>                 Key: THRIFT-4119
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4119
>             Project: Thrift
>          Issue Type: Bug
>          Components: Build Process
>    Affects Versions: 0.10.0
>            Reporter: Christopher Tubbs
>            Assignee: Jake Farrell
>            Priority: Critical
>
> The bootstrap.sh file is missing from the source tarball. This makes building from source difficult.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)