thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jeking3 <...@git.apache.org>
Subject [GitHub] thrift pull request #1350: Thrift 4325 - simplifying compiler location and e...
Date Sat, 09 Sep 2017 12:50:44 GMT
GitHub user jeking3 opened a pull request:

    https://github.com/apache/thrift/pull/1350

    Thrift 4325 - simplifying compiler location and enabling cross-compilation

    This is the application of #1336 merged into master - the original PR from @tpetazzoni
was a little stale so I fixed the conflicts and wanted to run it through CI again before committing
it.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jeking3/thrift THRIFT-4325

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1350.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1350
    
----
commit e87142cc64e5a3f2c827300e1ea45c9ae3997aa4
Author: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Date:   2017-08-25T22:10:40Z

    configure.ac, Makefile.am: introduce THRIFT variable to support cross-compilation
    
    The thrift build system currently assumes that the thrift compiler is
    always available in $(top_builddir)/compiler/cpp/thrift. However, in a
    cross-compilation context, this location contains the thrift compiler
    built for the target... which obviously will not run on the build
    machine.
    
    In order to support such cross-compilation situation, we introduce the
    THRIFT variable as a an argument for the configure script (using
    AC_ARG_VAR). If not specified, it defaults to the existing value of
    using compiler/cpp/thrift from the build directory, but it can be
    overridden when calling ./configure.
    
    Note that $(top_builddir) cannot be used within the configure script,
    so we simply use `pwd`, which is the same as the top_builddir.
    
    Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

commit 6388844159ea199f59cb24bda23e4aa615688615
Author: James E. King, III <jking@apache.org>
Date:   2017-09-09T04:26:16Z

    Merge branch 'cross-compilation-support' of https://github.com/tpetazzoni/thrift into
THRIFT-4325

----


---

Mime
View raw message