thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-4330) Allow unused crates in Rust files
Date Mon, 18 Sep 2017 11:14:01 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16169889#comment-16169889
] 

ASF GitHub Bot commented on THRIFT-4330:
----------------------------------------

Github user allengeorge commented on the issue:

    https://github.com/apache/thrift/pull/1360
  
    @sadikovi Sorry for the delay - was away this weekend.
    
    Ah, ok. That makes total sense. You probably don't have any floats in your IDL, or anything
that would use the `TryFrom` conversion. LGTM.
    
    @Jens-G LGTM; could you merge this please? TY!


> Allow unused crates in Rust files
> ---------------------------------
>
>                 Key: THRIFT-4330
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4330
>             Project: Thrift
>          Issue Type: Improvement
>            Reporter: Ivan Sadikov
>            Priority: Trivial
>             Fix For: 0.11.0
>
>
> Currently thrift generated .rs files include following attributes:
> #![allow(unused_imports)]
> #![cfg_attr(feature = "cargo-clippy", allow(too_many_arguments, type_complexity))]
> #![cfg_attr(rustfmt, rustfmt_skip)] 
> I propose to add 
> #![allow(unused_extern_crates)]
> to remove warning when using Rust nightly.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message