thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-4327) Improve TimerManager API to allow removing specific task
Date Thu, 21 Sep 2017 16:57:02 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16175095#comment-16175095
] 

ASF GitHub Bot commented on THRIFT-4327:
----------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/thrift/pull/1353


> Improve TimerManager API to allow removing specific task
> --------------------------------------------------------
>
>                 Key: THRIFT-4327
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4327
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Library
>            Reporter: Francois Ferrand
>            Assignee: James E. King, III
>
> The TimerManager::remove() method removes all timers with the specified callback, and
does so by traversing the list of timers.
> This should be improved by returning a "handle" in `TimerManager::add`, and supporting
efficiently removing a single timer from its handle:
> {code:java}
> class TimerManager {
>      Timer add(shared_ptr<Runnable> task, const struct timeval& value);
>      void remove(Timer t);
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message