thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-4295) Add an Ubuntu Xenial (16.04 LTS) Dockerfile
Date Fri, 01 Sep 2017 20:05:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16151081#comment-16151081
] 

ASF GitHub Bot commented on THRIFT-4295:
----------------------------------------

GitHub user jeking3 opened a pull request:

    https://github.com/apache/thrift/pull/1340

    THRIFT-4295: enable one build job with the new Ubuntu Xenial docker image

    Notes:
    
    For the D language I have openssl and libevent disabled in the xenial image for now. 
I ran into issues with the deimos for openssl and the version in the image; deimos supports
1.0.1g and xenial has 1.0.2g in it.  Will address in a separate PR.
    
    For php7 in xenial I had to make a TCP_NODELAY set conditional.  The required methods
didn't seem to exist in the OS provided php7 packages.  This didn't affect tests, apparently,
as they all passed.
    
    I added versions to every language in the configure output summary.
    
    I removed a generated file that was checked in (mock_handler.go).
    
    I added one travis build job using the new image to see how things go.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jeking3/thrift THRIFT-4295

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1340.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1340
    
----
commit 4bffa9fc8d735fe2c57f5e4f239c419b85844c3b
Author: James E. King, III <jking@apache.org>
Date:   2017-09-01T20:00:36Z

    THRIFT-4295: enable one build job with the new Ubuntu Xenial docker image and fix issues
encountered during the cutover locally

----


> Add an Ubuntu Xenial (16.04 LTS) Dockerfile
> -------------------------------------------
>
>                 Key: THRIFT-4295
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4295
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Build Process
>    Affects Versions: 0.11.0
>         Environment: docker, travis
>            Reporter: James E. King, III
>            Assignee: James E. King, III
>              Labels: docker, travis-ci, ubuntu
>
> Our current trusty dockerfile has a lot of special case configuration in it.  I have
been working on a xenial replacement which uses very little in the way of custom download
and config, instead relying on what Ubuntu provides in the base image.
> I am leaving the docker image "ubuntu" as it is, and making a new one called "ubuntu1604".
 Once it builds and runs we can start slowing moving build jobs over to it.
> So far here's what's on it:
> {noformat}
> C++     (C++11 default) gcc-5.4.0, clang-3.8
> c_glib  2.0
> java    1.8.0_131
> C# mono 5.2.0.215
> python  2.7.12, 3.5.2
> ruby    2.3.1p112
> haxe    3.2.1
> haskell 7.10.3
> perl    5.22.1
> php     7.0.22
> dart    1.24.2
> erlang  18.3
> go      1.6.2
> d       2.075.1
> NodeJS  8.4.0
> lua     5.3
> rust    1.15.1
> Intentionally leaving this out, for now (it wasn't in the trusty docker image either):
> dotnet  2.0.0
> Not in any images:
> cocoa
> smalltalk
> swift
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message