thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (THRIFT-4233) Make THsHaServer.invoker available (get method only) in inherited classes
Date Thu, 21 Sep 2017 20:36:00 GMT


ASF GitHub Bot commented on THRIFT-4233:

Github user dmvolod commented on the issue:
    @jeking3 , please review. The static is not acceptable to getInvoker as invoker is not
static context

> Make THsHaServer.invoker available (get method only) in inherited classes
> -------------------------------------------------------------------------
>                 Key: THRIFT-4233
>                 URL:
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Java - Library
>    Affects Versions: 0.10.0
>            Reporter: Dmitry Volodin
>            Assignee: James E. King, III
>            Priority: Minor
> In some cases (for example in Apache Camel component for Thrift) there is a requirement,
when it is necessary not only to transfer executorService from the external system through
the Args in THsHaServer , but to organize control them from outside. In this case, it's possible
to create a class which is inherited from THsHaServer, but not possible to access invoker
in overloaded gracefullyShutdownInvokerPool(). As workaround the TNonblockingServer must be
extended but requires to create several methods from scratch.
> It's necessary to add code below to THsHaServer
> {code:java}
> protected ExecutorService getInvoker() {
>   return invoker;
> }
> {code}
> I'm ready to add this code as PR.

This message was sent by Atlassian JIRA

View raw message