thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James E. King, III (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (THRIFT-3915) PSR(PHP Standard Recommendation) Conformance Violation
Date Sun, 24 Sep 2017 14:26:00 GMT

     [ https://issues.apache.org/jira/browse/THRIFT-3915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

James E. King, III resolved THRIFT-3915.
----------------------------------------
    Resolution: Duplicate

> PSR(PHP Standard Recommendation) Conformance Violation
> ------------------------------------------------------
>
>                 Key: THRIFT-3915
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3915
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Compiler (General)
>    Affects Versions: 0.9.3
>         Environment: Any
>            Reporter: Juwon Kim
>            Assignee: James E. King, III
>              Labels: build
>
> Hi there? I'm a server guy in Korea, mainly focuses on PHP development. I'm leaving this
issue to let you know that Thrift-generated code violates PSR(PHP Standard Recommendation).
And I'm asking you to follow the PHP community rules.
> I started using Apache Thrift a couple of days ago, I found out that Thrift-generated
code does not follow PSR-1. In a nutshell a PHP file should contain only one class(http://www.php-fig.org/psr/psr-1/#3-namespace-and-class-names),
but Thrift-generated one has many.
> The problem is that Thrift-generated classes cannot be autoloadable through PSR-4 autoload
standard(http://www.php-fig.org/psr/psr-4/#3-examples). The workaround is writing a home-made
autoloading logic, or taking advantage of symbolic link like https://github.com/appkr/psr4-autoload-test/
. Which is not elegant anyway.
> So I would like you to study the voice of PHP users on the importance of PSR.
> I hope to see your opinion soon.
> Thanks,
> appkr.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message