thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-3421) rebar as dependency instead of bundling (was: rebar fails if PWD contains Unicode)
Date Tue, 19 Sep 2017 11:59:02 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-3421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16171578#comment-16171578
] 

ASF GitHub Bot commented on THRIFT-3421:
----------------------------------------

Github user coveralls commented on the issue:

    https://github.com/apache/thrift/pull/693
  
    
    [![Coverage Status](https://coveralls.io/builds/13333850/badge)](https://coveralls.io/builds/13333850)
    
    Changes Unknown when pulling **16b3604f0ff0392cd1674e9bd41163bc0ab2b957 on bufferoverflow:THRIFT-3421**
into ** on apache:master**.



> rebar as dependency instead of bundling (was:  rebar fails if PWD contains Unicode)
> -----------------------------------------------------------------------------------
>
>                 Key: THRIFT-3421
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3421
>             Project: Thrift
>          Issue Type: Bug
>          Components: Build Process, Erlang - Library
>    Affects Versions: 0.9.3
>         Environment: Fedora release 23 (Twenty Three)
> Linux localhost.localdomain 4.2.5-300.fc23.x86_64 #1 SMP Tue Oct 27 04:29:56 UTC 2015
x86_64 x86_64 x86_64 GNU/Linux
> PWD=/home/lyokha/Загрузки/thrift-0.9.3
>            Reporter: Alexey Radkov
>            Assignee: Roger Meier
>            Priority: Minor
>             Fix For: 0.10.0
>
>
> When I build erlang support in a directory which contains Unicode characters I get following
error:
> {noformat}
> make[3]: вход в каталог «/home/lyokha/Загрузки/thrift-0.9.3/lib/erl»
> ./rebar get-deps
> ==> erl (get-deps)
> Uncaught error in rebar_core: {'EXIT',
>                                {badarg,
>                                 [{re,split,
>                                   [[80,87,68,61,47,104,111,109,101,47,108,121,
>                                     111,107,104,97,47,1047,1072,1075,1088,
>                                     1091,1079,1082,1080,47,116,104,114,105,
>                                     102,116,45,48,46,57,46,51,47,108,105,98,
>                                     47,101,114,108],
>                                    "=",
>                                    [{return,list},{parts,2}]],
>                                   [{file,"re.erl"},{line,170}]},
>                                  {rebar_port_compiler,'-os_env/0-lc$^0/1-0-',
>                                   1,[]},
>                                  {rebar_port_compiler,'-os_env/0-lc$^0/1-0-',
>                                   1,[]},
>                                  {rebar_port_compiler,os_env,0,[]},
>                                  {rebar_port_compiler,setup_env,1,[]},
>                                  {rebar_core,'-setup_envs/2-lc$^0/1-0-',2,[]},
>                                  {rebar_core,setup_envs,2,[]},
>                                  {rebar_core,execute,4,[]}]}}
> {noformat}
> The reason of this is that thrift uses very old prebuilt rebar:
> {noformat}
> rebar version: 2 date: 20110618_061440 vcs: git 3e41385
> {noformat}
> It does not include unicode option for _re:split_. Newer rebar (since 20 Nov 2012 https://github.com/rebar/rebar/commit/61c353dcfdafb87107cc5472709d229c26a8cb6c
revision) has this option.
> *Workaround*:
> install erlang-rebar package in the system and replace all _./rebar_ entries with _rebar_
in _lib/erl/Makefile.am_ (before running ./configure) or in _lib/erl/Makefile_ (after running
./configure).
> *Better fix* would be inclusion of a newer prebuilt rebar or create dependency on a system
rebar.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message