thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-2974) writeToParcel throws NPE for optional enum fields
Date Wed, 13 Sep 2017 05:18:03 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-2974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16164169#comment-16164169
] 

ASF GitHub Bot commented on THRIFT-2974:
----------------------------------------

Github user coveralls commented on the issue:

    https://github.com/apache/thrift/pull/687
  
    
    [![Coverage Status](https://coveralls.io/builds/13246571/badge)](https://coveralls.io/builds/13246571)
    
    Changes Unknown when pulling **fb9aec028a47f14ad8377799425277f4c77a7cfe on maxspencer:patch-1**
into ** on apache:master**.



> writeToParcel throws NPE for optional enum fields
> -------------------------------------------------
>
>                 Key: THRIFT-2974
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2974
>             Project: Thrift
>          Issue Type: Bug
>          Components: Java - Compiler
>    Affects Versions: 0.9.2, 0.9.3
>            Reporter: David Li
>            Assignee: Max Spencer
>             Fix For: 0.10.0
>
>
> The recent change to the Java compiler added generated Android compatible, parcelable
Thrift objects.
> https://github.com/apache/thrift/commit/f9b8f5e64137248ea2a1b95312916491d23ab94a#diff-80220be8df49fb98fe5f899544d8368dR1569
> However, for optional enum fields that are null, getValue() will throw an NPE because
no checks are made that the enum is set before being written.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message