thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jeking3 <...@git.apache.org>
Subject [GitHub] thrift pull request #1363: THRIFT-4331 - C++: TSSLSocket fixes
Date Fri, 15 Sep 2017 18:05:00 GMT
Github user jeking3 commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1363#discussion_r139214105
  
    --- Diff: lib/cpp/src/thrift/transport/TSSLSocket.cpp ---
    @@ -759,7 +775,9 @@ unsigned int TSSLSocket::waitForEvent(bool wantRead) {
       struct THRIFT_POLLFD fds[2];
       memset(fds, 0, sizeof(fds));
       fds[0].fd = fdSocket;
    -  fds[0].events = wantRead ? THRIFT_POLLIN : THRIFT_POLLOUT;
    +  // use POLLIN also on write operations too, this is needed for operations
    +  // which requires read and write on the socket.
    --- End diff --
    
    Interesting, what's an example of this?


---

Mime
View raw message