Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B46D22004A0 for ; Wed, 16 Aug 2017 21:29:08 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id B2D4C16973C; Wed, 16 Aug 2017 19:29:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0DBA016973A for ; Wed, 16 Aug 2017 21:29:07 +0200 (CEST) Received: (qmail 68050 invoked by uid 500); 16 Aug 2017 19:29:04 -0000 Mailing-List: contact dev-help@thrift.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@thrift.apache.org Delivered-To: mailing list dev@thrift.apache.org Received: (qmail 68039 invoked by uid 99); 16 Aug 2017 19:29:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Aug 2017 19:29:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 69CF8C376C for ; Wed, 16 Aug 2017 19:29:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id MMZ03M9LIAxf for ; Wed, 16 Aug 2017 19:29:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id EED8D5FC7B for ; Wed, 16 Aug 2017 19:29:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 3401CE0157 for ; Wed, 16 Aug 2017 19:29:02 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id D12782537D for ; Wed, 16 Aug 2017 19:29:00 +0000 (UTC) Date: Wed, 16 Aug 2017 19:29:00 +0000 (UTC) From: "Chris Bannister (JIRA)" To: dev@thrift.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 16 Aug 2017 19:29:08 -0000 [ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Bannister updated THRIFT-4285: ------------------------------------ Attachment: 0001-go-pull-generated-send-recv-into-lib-v3.patch Export TStandardClient as it can be useful for those wanting to implement connection pools and maintain their own transports. Retain existing error format including method name. > Pull generated send/recv into library to allow behaviour to be customised > ------------------------------------------------------------------------- > > Key: THRIFT-4285 > URL: https://issues.apache.org/jira/browse/THRIFT-4285 > Project: Thrift > Issue Type: Improvement > Components: Go - Compiler, Go - Library > Reporter: Chris Bannister > Assignee: Chris Bannister > Attachments: 0001-go-pull-generated-send-recv-into-lib-2.patch, 0001-go-pull-generated-send-recv-into-lib.patch, 0001-go-pull-generated-send-recv-into-lib-v3.patch > > > Currently it is difficult to change how thrift writes messages onto the transport because they are in the generated code. Instead the generated send/recv methods should be in the library. This will greatly simplify the client code and remove many duplicate methods whilst allowing users more flexibility to implement connection pools and other features such as THeader. -- This message was sent by Atlassian JIRA (v6.4.14#64029)