Mailing-List: contact dev-help@thrift.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@thrift.apache.org
Date: Sat, 12 Aug 2017 23:25:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@thrift.apache.org
Message-ID: <JIRA.12980822.1466424121000.19746.1502580300081@Atlassian.JIRA>
In-Reply-To: <JIRA.12980822.1466424121000@Atlassian.JIRA>
References: <JIRA.12980822.1466424121000@Atlassian.JIRA> <JIRA.12980822.1466424121363@jira-lw-us.apache.org>
Subject: [jira] [Commented] (THRIFT-3857) thrift js:node complier support an
 object as parameter not an instance of struct
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Sat, 12 Aug 2017 23:25:06 -0000


    [ https://issues.apache.org/jira/browse/THRIFT-3857?page=3Dcom.atlassia=
n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D161=
24747#comment-16124747 ]=20

ASF GitHub Bot commented on THRIFT-3857:
----------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/thrift/pull/1034


> thrift js:node complier support an object as parameter not an instance of=
 struct
> -------------------------------------------------------------------------=
-------
>
>                 Key: THRIFT-3857
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3857
>             Project: Thrift
>          Issue Type: New Feature
>          Components: Node.js - Compiler
>    Affects Versions: 0.9.3, 0.10.0
>            Reporter: jiangq
>            Assignee: James E. King, III
>             Fix For: 0.11.0
>
>
> use the tutorial.thrift,code like:
> {code:javascript}
> let param =3D {
>   op: ttypes.Operation.DIVIDE,
>   num1: 1,
>   num2: 0
> }
> let work =3D new ttypes.Work(param);
> client.calculate(1, work)
>   .then(function(message) {
> =09console.log('Whoa? You know how to divide by zero?');
>   })
>   .fail(function(err) {
>     console.log("InvalidOperation " + err);
>   });
> {code}
> can we support like these:
> {code:javascript}
> let work =3D {
>   op: ttypes.Operation.DIVIDE,
>   num1: 1,
>   num2: 0
> }
> client.calculate(1, work)
>   .then(function(message) {
> =09console.log('Whoa? You know how to divide by zero?');
>   })
>   .fail(function(err) {
>     console.log("InvalidOperation " + err);
>   });
> {code}
> If we can support this feature will be very convenient=EF=BC=8C and I hav=
e read the 't_js_generator.cc' file, find this feature is easy to support, =
can we add the support for this feature?


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)