thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tpetazzoni <...@git.apache.org>
Subject [GitHub] thrift pull request #1336: configure.ac, Makefile.am: introduce THRIFT varia...
Date Sat, 26 Aug 2017 14:25:19 GMT
GitHub user tpetazzoni opened a pull request:

    https://github.com/apache/thrift/pull/1336

    configure.ac, Makefile.am: introduce THRIFT variable to support cross…

    …-compilation
    
    The thrift build system currently assumes that the thrift compiler is
    always available in $(top_builddir)/compiler/cpp/thrift. However, in a
    cross-compilation context, this location contains the thrift compiler
    built for the target... which obviously will not run on the build
    machine.
    
    In order to support such cross-compilation situation, we introduce the
    THRIFT variable as a an argument for the configure script (using
    AC_ARG_VAR). If not specified, it defaults to the existing value of
    using compiler/cpp/thrift from the build directory, but it can be
    overridden when calling ./configure.
    
    Note that $(top_builddir) cannot be used within the configure script,
    so we simply use `pwd`, which is the same as the top_builddir.
    
    Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tpetazzoni/thrift cross-compilation-support

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1336.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1336
    
----
commit e87142cc64e5a3f2c827300e1ea45c9ae3997aa4
Author: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Date:   2017-08-25T22:10:40Z

    configure.ac, Makefile.am: introduce THRIFT variable to support cross-compilation
    
    The thrift build system currently assumes that the thrift compiler is
    always available in $(top_builddir)/compiler/cpp/thrift. However, in a
    cross-compilation context, this location contains the thrift compiler
    built for the target... which obviously will not run on the build
    machine.
    
    In order to support such cross-compilation situation, we introduce the
    THRIFT variable as a an argument for the configure script (using
    AC_ARG_VAR). If not specified, it defaults to the existing value of
    using compiler/cpp/thrift from the build directory, but it can be
    overridden when calling ./configure.
    
    Note that $(top_builddir) cannot be used within the configure script,
    so we simply use `pwd`, which is the same as the top_builddir.
    
    Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message