thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-2221) Generate c++ code with std::shared_ptr instead of boost::shared_ptr.
Date Tue, 08 Aug 2017 19:50:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118928#comment-16118928
] 

ASF GitHub Bot commented on THRIFT-2221:
----------------------------------------

Github user jeking3 commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1328#discussion_r132013676
  
    --- Diff: lib/cpp/README.md ---
    @@ -55,15 +54,22 @@ you are using libthriftnb you will also need libevent.
     
     ## Dependencies
     
    -boost shared pointers
    -http://www.boost.org/libs/smart_ptr/smart_ptr.htm
    +If your C++ environment implements C++11 or later, boost will automatically use
    --- End diff --
    
    Got it, I can correct this.  I'm still dealing with aligning the stars on this one.  Lots
of namespace and using cleanup, and we will no longer work with Visual Studio 2010 and 2012
in C++0x/C++11 mode; 2013 will be required for C++11 because the solution requires template
aliases.


> Generate c++ code with std::shared_ptr instead of boost::shared_ptr.
> --------------------------------------------------------------------
>
>                 Key: THRIFT-2221
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2221
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Compiler
>    Affects Versions: 0.9.1
>         Environment: C++11 compilers with std::shared_ptr support
>            Reporter: Chris Stylianou
>            Assignee: James E. King, III
>              Labels: c++11, compiler, thrift
>
> Most modern compilers now have full support for std::shared_ptr when enable with c++11
flags. It would be nice to have the option to generate code that uses this instead of boost::shared_ptr.
This would enable us to remove another boost dependency, on the road to a dependency-free
thrift library :)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message