thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jeking3 <...@git.apache.org>
Subject [GitHub] thrift pull request #1326: THRIFT-3821
Date Fri, 11 Aug 2017 03:08:51 GMT
Github user jeking3 commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1326#discussion_r132611133
  
    --- Diff: lib/cpp/test/TMemoryBufferTest.cpp ---
    @@ -117,4 +117,17 @@ BOOST_AUTO_TEST_CASE(test_exceptions) {
       BOOST_CHECK_NO_THROW(buf2.write((const uint8_t*)"bar", 3));
     }
     
    +#ifndef _WIN32
    +// We can't allocate 1 GB of memory in 32-bit environments.
    --- End diff --
    
    This makes me wonder if the TBufferTransport should have a size limit that is configurable,
with a default of INT32_MAX, and then the test can make a smaller one like 4KB, and write
4KB and then one byte more, instead of using up 2GB of memory.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message