Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 51ACF200CE0 for ; Wed, 26 Jul 2017 22:31:08 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 5008C169897; Wed, 26 Jul 2017 20:31:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 96D11169895 for ; Wed, 26 Jul 2017 22:31:07 +0200 (CEST) Received: (qmail 10298 invoked by uid 500); 26 Jul 2017 20:31:06 -0000 Mailing-List: contact dev-help@thrift.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@thrift.apache.org Delivered-To: mailing list dev@thrift.apache.org Received: (qmail 10127 invoked by uid 99); 26 Jul 2017 20:31:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Jul 2017 20:31:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 622501A1DD9 for ; Wed, 26 Jul 2017 20:31:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id X-FrlCfZ1tS9 for ; Wed, 26 Jul 2017 20:31:04 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 33BF761B4E for ; Wed, 26 Jul 2017 20:31:03 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9372CE00A3 for ; Wed, 26 Jul 2017 20:31:02 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 8B3FB24D30 for ; Wed, 26 Jul 2017 20:31:01 +0000 (UTC) Date: Wed, 26 Jul 2017 20:31:01 +0000 (UTC) From: "Jens Geyer (JIRA)" To: dev@thrift.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Closed] (THRIFT-4261) Go context generation issue: breaking change in generated code regarding thrift.TProcessorFunction interface MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 26 Jul 2017 20:31:08 -0000 [ https://issues.apache.org/jira/browse/THRIFT-4261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer closed THRIFT-4261. ------------------------------ Resolution: Not A Problem Assignee: Jens Geyer (was: taozle) Fix Version/s: 0.11.0 > Go context generation issue: breaking change in generated code regarding thrift.TProcessorFunction interface > ------------------------------------------------------------------------------------------------------------ > > Key: THRIFT-4261 > URL: https://issues.apache.org/jira/browse/THRIFT-4261 > Project: Thrift > Issue Type: Bug > Components: Go - Compiler, Go - Library > Environment: generated code for Golang > Reporter: Yicheng Qin > Assignee: Jens Geyer > Fix For: 0.11.0 > > > I observe the breaking change in `thrift.TProcessorFunction` interface that adds a `Context` parameter, and corresponded breaking change in the generated client code. > So the generated code from v0.9 thrift compiler can no longer run with the master thrift library. > I understand you expect that we should use the same version of compiler and library for the same repository. But this is super hard in reality: > 1. Lots of repos store the generated code, e.g., https://github.com/uber/jaeger-client-go/blob/master/thrift-gen/jaeger/agent.go . So it could use either old interface or new interface. > 2. Go projects always use `glide` as version management, which uses single version for one library across the repository. If one dep relies on old interface, and one dep relies on new interface, the project will totally break. -- This message was sent by Atlassian JIRA (v6.4.14#64029)