Mailing-List: contact dev-help@thrift.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@thrift.apache.org
Date: Sun, 23 Jul 2017 09:29:01 +0000 (UTC)
From: "Bas van Beek (JIRA)" <jira@apache.org>
To: dev@thrift.apache.org
Message-ID: <JIRA.13089304.1500802091000.310335.1500802141897@Atlassian.JIRA>
In-Reply-To: <JIRA.13089304.1500802091000@Atlassian.JIRA>
References: <JIRA.13089304.1500802091000@Atlassian.JIRA> <JIRA.13089304.1500802091201@jira-lw-us.apache.org>
Subject: [jira] [Created] (THRIFT-4260) Go context generation issue. Context
 is parameter in Interface not in implementation
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sun, 23 Jul 2017 09:29:15 -0000

Bas van Beek created THRIFT-4260:
------------------------------------

             Summary: Go context generation issue. Context is parameter in Interface not in implementation
                 Key: THRIFT-4260
                 URL: https://issues.apache.org/jira/browse/THRIFT-4260
             Project: Thrift
          Issue Type: Bug
          Components: Go - Compiler
    Affects Versions: 0.11.0
            Reporter: Bas van Beek


Unfortunately the Go library was updated before a new Compiler was released. Having thrift compiled code be part in a project prior to the thrift context library addition breaks due to the dependency on the thrift go library. See: https://github.com/openzipkin/zipkin-go-opentracing/issues/68

I tried to resolve be installing compiler from latest source but found the generated source to be incorrect. The generated Go interface for the service client includes context.Context as the first parameter of the service method. The generated client implementation however does not.

The following thrift code:

{{
enum ResultCode
{
  OK,
  TRY_LATER
}

struct LogEntry
{
  1:  string category,
  2:  string message
}

service Scribe
{
  ResultCode Log(1: list<LogEntry> messages);
}
}}

Generated the following Go code:
{{
type Scribe interface {
	// Parameters:
	//  - Messages
	Log(ctx context.Context, messages []*LogEntry) (r ResultCode, err error)
}

...

// Parameters:
//  - Messages
func (p *ScribeClient) Log(messages []*LogEntry) (r ResultCode, err error) {
	if err = p.sendLog(messages); err != nil {
		return
	}
	return p.recvLog()
}

}}


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)