thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dcelasun <...@git.apache.org>
Subject [GitHub] thrift issue #1309: Use build tags to support context.
Date Sun, 23 Jul 2017 11:02:51 GMT
Github user dcelasun commented on the issue:

    https://github.com/apache/thrift/pull/1309
  
    Ah, now I see it. The Makefile for the tutorial has the `legacy_context` flag hardcoded,
since it's pinned to the Go version included in the Docker container. If you are running it
outside the container (and hence with Go 1.7+) you need to remove `legacy_context` and `thirdparty-dep`
from the Makefile.
    
    @taozle Maybe there is a way to check the go version before adding the flag?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message