thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From taozle <...@git.apache.org>
Subject [GitHub] thrift pull request #1309: Use build tags to support context.
Date Wed, 19 Jul 2017 06:16:36 GMT
Github user taozle commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1309#discussion_r128160543
  
    --- Diff: compiler/cpp/src/thrift/generate/t_go_generator.cc ---
    @@ -3746,4 +3746,4 @@ THRIFT_REGISTER_GENERATOR(go, "Go",
                               "    read_write_private\n"
                               "                     Make read/write methods private, default
is public Read/Write\n" \
                               "    use_context\n"
    -                          "                     Make service method receive a context
as first argument.\n")
    +                          "                     Make service method receive a context
as first argument, only go1.7+ is supported.\n")
    --- End diff --
    
    Sounds good, i will update this PR later today.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message