thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From juliengreard <>
Subject [GitHub] thrift pull request #1293: THRIFT-2642 Recursive structs don't work in pytho...
Date Wed, 05 Jul 2017 22:23:28 GMT
Github user juliengreard commented on a diff in the pull request:
    --- Diff: lib/py/src/ ---
    @@ -0,0 +1,63 @@
    +# MODIFIED June 20, 2017, Eric Conner
    +# Original source copyright 2014-present Facebook, Inc.
    +# Licensed under the Apache License, Version 2.0 (the "License");
    +# you may not use this file except in compliance with the License.
    +# You may obtain a copy of the License at
    +# Unless required by applicable law or agreed to in writing, software
    +# distributed under the License is distributed on an "AS IS" BASIS,
    +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +# See the License for the specific language governing permissions and
    +# limitations under the License.
    +from __future__ import absolute_import
    +from __future__ import division
    +from __future__ import print_function
    +from __future__ import unicode_literals
    +from thrift.Thrift import TType
    +def fix_spec(all_structs):
    --- End diff --
    Well I'm sorry but I dont understand this file. Maybe explaining what the functions are
doing would help. You could also use named variables instead of using directly 'magic' numbers
(like const static int name = 1). But I may be wrong, I'm a complete stranger to the source
code of thrift, so maybe it's the way to do it

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message