Mailing-List: contact dev-help@thrift.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@thrift.apache.org
Date: Sat, 3 Jun 2017 09:48:04 +0000 (UTC)
From: "Jens Geyer (JIRA)" <jira@apache.org>
To: dev@thrift.apache.org
Message-ID: <JIRA.13076922.1496426036000.359049.1496483284113@Atlassian.JIRA>
In-Reply-To: <JIRA.13076922.1496426036000@Atlassian.JIRA>
References: <JIRA.13076922.1496426036000@Atlassian.JIRA> <JIRA.13076922.1496426036042@jira-lw-us.apache.org>
Subject: [jira] [Commented] (THRIFT-4220) Allow Service calls to be made
 using TSimpleJSONProtocol (using Simple JSON)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Sat, 03 Jun 2017 09:48:08 -0000


    [ https://issues.apache.org/jira/browse/THRIFT-4220?page=3Dcom.atlassia=
n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D160=
35915#comment-16035915 ]=20

Jens Geyer commented on THRIFT-4220:
------------------------------------

TSimnpleJSON was never intended to be used as means of transport in Thrift.=
 I don't see the value w/regard to the [Thrift Goals|http://thrift.apache.o=
rg/about], especially since we already have TJSONProtocol which adheres muc=
h more to them:

{quote}
Apache Thrift aims to embody the following values:

=E2=80=A2 Simplicity Thrift code is simple and approachable, free of unnece=
ssary dependencies.
=E2=80=A2 Transparency Thrift conforms to the most common idioms in all lan=
guages.
=E2=80=A2 Consistency Niche, language-specific features belong in extension=
s, not the core library.
=E2=80=A2 Performance Strive for performance first, elegance second.
{quote}

TL;DR: I tend to disagree.

> Allow Service calls to be made using TSimpleJSONProtocol (using Simple JS=
ON)
> -------------------------------------------------------------------------=
---
>
>                 Key: THRIFT-4220
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4220
>             Project: Thrift
>          Issue Type: New Feature
>          Components: Wish List
>    Affects Versions: 1.0
>            Reporter: Devansh Gupta
>             Fix For: 1.0
>
>
> https://blog.parsable.com/using-human-readable-json-endpoints-with-thrift=
-for-free-774ba505c893
> https://github.com/degupta/human_readable_json_protocol
> If we publish our Services/APIs as Thrift today you can't make requests u=
sing simple Human Readable JSON. This means publishing our APIs to third pa=
rty users means they have to
> 1. Know how to use Thrift
> 2. Have all the Thrift definition files or the generated code
> Or we have to build Libraries for each of the platforms we want to suppor=
t.
> This is not always possible.
> I propose we do something like this:
> {code}
> exception SystemException {
>   1: i32 errorCode,
>   2: string message,
> }
> struct User {
>   1: string id,
>   2: string email,
>   3: string name,
>   4: i64 validatedAt
> }
> struct LoginResult {
>   1: string authToken,
>   2: User currentUser
> }
> service AuthenticationService {
>   LoginResult login(1: string email, 2: string password) throws(1: System=
Exception err)
> }
> {code}
> Request Format:
> {code}
> {
>   "method": "METHOD_NAME",
>   "arguments": { ... }
> }
> {
>   "method": "login",
>   "arguments": {
>     "email": "devansh@wi.co",
>     "password": "password"
>   }
> }
> {code}
> RESULT:
> {code}
> {
>   "method": "login",
>   "result": {
>     "success": {
>       "authToken": "some_auth_token",
>       "currentUser": {
>         "id": "6a6c982b-62f9-46d2-aff9-bd3a1cdf43f9",
>         "email": "user1@wi.co",
>         "name": "user1",
>         "validatedAt": 0
>       }
>     }
>   }
> }
> {code}
> This uses the JSON generated by the JSON Generator as "metadata" to figur=
e out the Field Keys and Types.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)