Mailing-List: contact dev-help@thrift.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@thrift.apache.org
From: mfrawley <git@git.apache.org>
To: dev@thrift.apache.org
Reply-To: dev@thrift.apache.org
References: <git-pr-1283-thrift@git.apache.org>
In-Reply-To: <git-pr-1283-thrift@git.apache.org>
Subject: [GitHub] thrift issue #1283: THRIFT-4218: Set TCP_NODELAY for PHP client socket
Content-Type: text/plain
Message-Id: <20170606115517.B2333E0061@git1-us-west.apache.org>
Date: Tue,  6 Jun 2017 11:55:17 +0000 (UTC)
archived-at: Tue, 06 Jun 2017 11:55:20 -0000

Github user mfrawley commented on the issue:

    https://github.com/apache/thrift/pull/1283
  
    I'd just like to add that we deployed a similar fix to this on our infrastructure at Jimdo which led to this PR. We have a large PHP codebase which communicates with some services over Thrift. 
     We support ~20 million websites and our logging and metrics indicate fewer timeouts after this change. We had tried several other tweaks previously and this seems to have had a bigger effect than raising the read/write timeouts (at least by a conservative amount).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---