thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zwass <...@git.apache.org>
Subject [GitHub] thrift pull request #1301: THRIFT-4240 Fix use of sync.Once in Go TSimpleSer...
Date Tue, 27 Jun 2017 19:06:42 GMT
GitHub user zwass opened a pull request:

    https://github.com/apache/thrift/pull/1301

    THRIFT-4240 Fix use of sync.Once in Go TSimpleServer Stop() method

    A package global sync.Once was used, which ensured that Stop() could only be
    called once *per process*. The correct semantics should be once *per server*.
    
    This commit makes the sync.Once a member of the server struct so that the
    correct semantics are applied.
    
    https://issues.apache.org/jira/browse/THRIFT-4240

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zwass/thrift THRIFT-4240

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1301.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1301
    
----
commit 3f0444f8292a6ca1889e9812b805759eb8a74255
Author: Zachary Wasserman <zachwass2000@gmail.com>
Date:   2017-06-27T19:03:39Z

    THRIFT-4240 Fix use of sync.Once in Go TSimpleServer Stop() method
    
    A package global sync.Once was used, which ensured that Stop() could only be
    called once *per process*. The correct semantics should be once *per server*.
    
    This commit makes the sync.Once a member of the server struct so that the
    correct semantics are applied.
    
    https://issues.apache.org/jira/browse/THRIFT-4240

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message