thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-4215) Golang TTransportFactory Pattern Squelches Errors
Date Fri, 02 Jun 2017 14:15:04 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16034756#comment-16034756
] 

ASF GitHub Bot commented on THRIFT-4215:
----------------------------------------

Github user dcelasun commented on the issue:

    https://github.com/apache/thrift/pull/1285
  
    Closing PR until all tests are fixed, I don't want to waste Apache's Travis capacity.


> Golang TTransportFactory Pattern Squelches Errors
> -------------------------------------------------
>
>                 Key: THRIFT-4215
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4215
>             Project: Thrift
>          Issue Type: Bug
>          Components: Go - Library
>    Affects Versions: 0.10.0
>            Reporter: James Mouradian
>            Assignee: Can Celasun
>
> The current (as of 72ca60d) pattern for [TTransport factories|https://github.com/apache/thrift/blob/master/lib/go/thrift/transport_factory.go#L26]
in Golang is 
> {code}
> type TTransportFactory interface {
> 	GetTransport(trans TTransport) TTransport
> }
> {code}
> This causes issues, because some {{TTransportFactory}} implementations can return and
error. Consider the [THttpClientTransportFactory|https://github.com/apache/thrift/blob/master/lib/go/thrift/http_client.go#L52],
which as of of 72ca60d, includes the following snippet:
>  
> {code}
> 	s, _ := NewTHttpClientWithOptions(p.url, p.options)
> 	return s
> {code}
> The call to {{NewTHttpClientWithOptions(...)}} call can throw errors. The resultant behavior
is that {{nil}} is returned in place of a valid {{TTransport}}, with a {{nil}} error.
> The {{TTransportFactory}} interface (and associated use patterns) should be extended
to include errors.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message