thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mario Emmenlauer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-2221) Generate c++ code with std::shared_ptr instead of boost::shared_ptr.
Date Sun, 04 Jun 2017 20:26:04 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036380#comment-16036380
] 

Mario Emmenlauer commented on THRIFT-2221:
------------------------------------------

The patch works on several Linux derivates, but not on all. On CentOS 7.3 and Ubuntu 14.04
I get an error:
{code}
[...]
In file included from /data/thrift-trunk-r2b1b32c/lib/cpp/src/thrift/async/TAsyncChannel.h:23:0,
                 from /data/thrift-trunk-r2b1b32c/lib/cpp/src/thrift/async/TAsyncChannel.cpp:20:
/data/thrift-trunk-r2b1b32c/lib/cpp/src/thrift/stdcxx.h:129:20: error: 'boost::scoped_ptr'
has not been declared
     using ::boost::scoped_ptr;
                    ^
{code}

> Generate c++ code with std::shared_ptr instead of boost::shared_ptr.
> --------------------------------------------------------------------
>
>                 Key: THRIFT-2221
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2221
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Compiler
>    Affects Versions: 0.9.1
>         Environment: C++11 compilers with std::shared_ptr support
>            Reporter: Chris Stylianou
>            Assignee: James E. King, III
>              Labels: c++11, compiler, thrift
>
> Most modern compilers now have full support for std::shared_ptr when enable with c++11
flags. It would be nice to have the option to generate code that uses this instead of boost::shared_ptr.
This would enable us to remove another boost dependency, on the road to a dependency-free
thrift library :)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message