Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B9D81200C88 for ; Thu, 18 May 2017 23:29:09 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id B895F160B9D; Thu, 18 May 2017 21:29:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1E3A7160BB5 for ; Thu, 18 May 2017 23:29:08 +0200 (CEST) Received: (qmail 32558 invoked by uid 500); 18 May 2017 21:29:08 -0000 Mailing-List: contact dev-help@thrift.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@thrift.apache.org Delivered-To: mailing list dev@thrift.apache.org Received: (qmail 32547 invoked by uid 99); 18 May 2017 21:29:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 May 2017 21:29:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id E2BE0C0620 for ; Thu, 18 May 2017 21:29:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id hdtzOsAf5HrN for ; Thu, 18 May 2017 21:29:07 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 4AE3860D01 for ; Thu, 18 May 2017 21:29:06 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 42A57E0DBA for ; Thu, 18 May 2017 21:29:05 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 6A7C823FD6 for ; Thu, 18 May 2017 21:29:04 +0000 (UTC) Date: Thu, 18 May 2017 21:29:04 +0000 (UTC) From: "Jens Geyer (JIRA)" To: dev@thrift.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (THRIFT-4203) thrift server stop gracefully MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 18 May 2017 21:29:09 -0000 [ https://issues.apache.org/jira/browse/THRIFT-4203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-4203. -------------------------------- Resolution: Fixed Fix Version/s: (was: 0.10.0) 0.11.0 Committed, thanks. BTW, the Add() should be made before go ... to prevent a race condition. > thrift server stop gracefully > ----------------------------- > > Key: THRIFT-4203 > URL: https://issues.apache.org/jira/browse/THRIFT-4203 > Project: Thrift > Issue Type: Improvement > Components: Go - Library > Affects Versions: 0.10.0 > Reporter: binbin li > Assignee: Jens Geyer > Labels: github-import > Fix For: 0.11.0 > > > When the service is closed, it simply exits the listener function and immediately exits without waiting for the goroutines to be stopped by the request being processed, which results in inconsistent services and data -- This message was sent by Atlassian JIRA (v6.3.15#6346)