thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James M (JIRA)" <>
Subject [jira] [Created] (THRIFT-4216) Golang Http Clients Do Not Respect User Options
Date Tue, 30 May 2017 18:04:04 GMT
James M created THRIFT-4216:

             Summary: Golang Http Clients Do Not Respect User Options
                 Key: THRIFT-4216
             Project: Thrift
          Issue Type: Bug
          Components: Go - Library
            Reporter: James M

As of 72ca60d, the instantiation of an http client with user-supplied options ([NewTHttpClientWithOptions|])
disregards options. 

The target endpoint is tested with the following snippet:
response, err := http.Get(urlstr)

However, a user-supplied {{THttpClientOptions}} contains a client that should be used to test
the endpoint instead, i.e., 

response, err := options.Client.Get(urlstr)

The user-supplied client may have settings that are required to communicate with the target

Though this fix seems simple, I have not supplied a patch, as this fix should likely be bundled
with a greater overarching patch to THRIFT-4215. That is because the single line change above
may not include all the fixes necessary to propagate client options correctly through the
construction of a {{THttpTransport}}, and further errors are squelched.

This message was sent by Atlassian JIRA

View raw message