thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-4207) Accelerated version of TBinaryProtocol allows invalid input to string fields.
Date Tue, 23 May 2017 16:43:04 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021439#comment-16021439
] 

ASF GitHub Bot commented on THRIFT-4207:
----------------------------------------

GitHub user elprans opened a pull request:

    https://github.com/apache/thrift/pull/1274

    THRIFT-4207: Make sure Python Accelerated protocol does not allow invalid UTF-8

    The accelerated version of Binary and Compact protocol fails to validate
    the input string for UTF-8 fields.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/elprans/thrift python-fastbinary-utf8-validation

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1274.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1274
    
----
commit e030430e90ec5d7dff1db8dd98f36b6171c9a866
Author: Elvis Pranskevichus <elvispranskevichus@pinterest.com>
Date:   2017-05-23T15:50:38Z

    THRIFT-4207: Make sure Python Accelerated protocol does not allow invalid UTF-8 in.
    
    The accelerated version of Binary and Compact protocol fails to validate
    the input string for UTF-8 fields.

----


> Accelerated version of TBinaryProtocol allows invalid input to string fields.
> -----------------------------------------------------------------------------
>
>                 Key: THRIFT-4207
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4207
>             Project: Thrift
>          Issue Type: Bug
>          Components: Python - Library
>    Affects Versions: 0.10.0
>            Reporter: Elvis Pranskevichus
>             Fix For: 0.11.0
>
>
> {{TBinaryProtocolAccelerated}} and {{TCompactProtocolAccelerated}} currently accept arbitrary
bytes as input to string fields even when {{py:utf8strings}} is on.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message