thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Can Celasun (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (THRIFT-3466) Set Parameters Have Wrong Key Type in Go Code
Date Tue, 30 May 2017 11:39:04 GMT

     [ https://issues.apache.org/jira/browse/THRIFT-3466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Can Celasun resolved THRIFT-3466.
---------------------------------
       Resolution: Fixed
    Fix Version/s: 0.10.0

This was fixed with [431732d|https://github.com/apache/thrift/commit/431732d39e89f1661dc7dddffedb2c5c1e019cc7].
See [here|https://github.com/dcelasun/misc/tree/master/thrift/THRIFT-3466| for the IDL file
and generated code.

> Set Parameters Have Wrong Key Type in Go Code
> ---------------------------------------------
>
>                 Key: THRIFT-3466
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3466
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Go - Compiler
>    Affects Versions: 0.9.3
>         Environment: Go 1.4.2
> Thrift 0.9.3
> Ubuntu Linux 14.04
> amd64
>            Reporter: Tom Deering
>              Labels: golang
>             Fix For: 0.10.0
>
>
> When Thrift 0.9.3 generates Go code for a service with a parameter that is of type set<typedeffed
thing>, the generated Go code parameter is of type map[untypedeffed thing]bool. For example:
> Thrift
> {code}
> namespace go bug
> typedef string Foo
> service FooService{
> 	void bar (1:set<Foo> foos)
> }
> {code}
> Go
> {code}
> func (p *FooServiceClient) Bar(foos map[string]bool) (err error) 
> {code}
> The key type of the Go map should be Foo, not string.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message