Mailing-List: contact dev-help@thrift.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@thrift.apache.org
Date: Wed, 5 Apr 2017 15:37:41 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@thrift.apache.org
Message-ID: <JIRA.12970152.1463433439000.211675.1491406661758@Atlassian.JIRA>
In-Reply-To: <JIRA.12970152.1463433439000@Atlassian.JIRA>
References: <JIRA.12970152.1463433439000@Atlassian.JIRA> <JIRA.12970152.1463433439174@jira-lw-us.apache.org>
Subject: [jira] [Commented] (THRIFT-3828) cmake fails when
 Boost_INCLUDE_DIRS (and other variables passed to include_directories()) is
 empty
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 05 Apr 2017 15:37:46 -0000


    [ https://issues.apache.org/jira/browse/THRIFT-3828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957043#comment-15957043 ] 

ASF GitHub Bot commented on THRIFT-3828:
----------------------------------------

Github user jfarrell closed the pull request at:

    https://github.com/apache/thrift/pull/1082


> cmake fails when Boost_INCLUDE_DIRS (and other variables passed to include_directories()) is empty 
> ---------------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-3828
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3828
>             Project: Thrift
>          Issue Type: Bug
>          Components: Build Process
>            Reporter: Cody Schafer
>            Assignee: James E. King, III
>            Priority: Minor
>             Fix For: 0.10.0
>
>         Attachments: 0001-cmake-avoid-use-of-both-quoted-paths-and-SYSTEM-with.patch
>
>
> This is due to the current quoting of those variables when passed to `include_directories()`. These variables may (and soon will, see below) be empty in the case where the include directory is a system include path that is implicitly included.
> I ran into this issue when trying to build thrift using gcc-6. gcc-6 doesn't work with includes that are part of the platform/system include path (see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129 for one mention). To resolve this, `FindBoost.cmake` will be adjusted to avoid adding those types of directories to Boost_INCLUDE_DIRS.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)