thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From allengeorge <...@git.apache.org>
Subject [GitHub] thrift pull request #1255: THRIFT-4176: Implement threaded server for Rust
Date Thu, 20 Apr 2017 23:43:45 GMT
GitHub user allengeorge opened a pull request:

    https://github.com/apache/thrift/pull/1255

    THRIFT-4176: Implement threaded server for Rust

    Client: rs
    
    * Separate TTransport into two constructs: TIoChannel and TTransport
    * Make TIoChannel and TTransport Send-able types
    * Remove refcounting where possible
    * Replace TSimpleServer with a thread-pool based TServer
    
    The removal of refcounting was driven by the need to make constructs threadsafe. I'd always
known the ref-counting was hacky; this approach pushes the counting/locking into a separate
`TIoChannel` concept that can be cloned to simplify the ownership story for all the concepts
above. Also, as requested, I didn't *add* a new server type: I replaced the existing one with
this threadpool-based version.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/allengeorge/thrift thrift-4176

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1255.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1255
    
----
commit 0a0592f333ea4c9be64dd83fa7ce6e78c7307567
Author: Allen George <allen.george@gmail.com>
Date:   2017-01-30T12:15:00Z

    THRIFT-4176: Implement threaded server for Rust
    Client: rs
    
    * Separate TTransport into two constructs: TIoChannel and TTransport
    * Make TIoChannel and TTransport Send-able types
    * Remove refcounting where possible
    * Replace TSimpleServer with a thread-pool based TServer

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message