thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-4177) Java compiler produces deep copy constructor that could make shallow copy instead
Date Wed, 19 Apr 2017 06:29:42 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974162#comment-15974162
] 

ASF GitHub Bot commented on THRIFT-4177:
----------------------------------------

Github user afds commented on the issue:

    https://github.com/apache/thrift/pull/1254
  
    Are you sure? I don't really understand what should I update there.


> Java compiler produces deep copy constructor that could make shallow copy instead
> ---------------------------------------------------------------------------------
>
>                 Key: THRIFT-4177
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4177
>             Project: Thrift
>          Issue Type: Bug
>          Components: Java - Compiler
>    Affects Versions: 0.9.2
>            Reporter: Deniss Afonin
>
> Java compiler produces deep copy constructor that makes shallow copies for referenced
objects from collections when they are defined after the root object in the thrift file.
> For example, consider following thrift file:
> struct Foo {
> 1: optional list<Bar> bars,
> }
> struct Bar {
> 1: optional string value,
> }
> new Foo().deepCopy() will produce a copy of Foo with a copy of a list that reference
the same Bar object.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message