thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adriaan Schmidt (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-4140) Use of non-thread-safe function gmtime()
Date Mon, 03 Apr 2017 06:03:41 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15953031#comment-15953031
] 

Adriaan Schmidt commented on THRIFT-4140:
-----------------------------------------

Oh, I wasn't aware of Windows...
Thanks for fixing this so quickly!

> Use of non-thread-safe function gmtime()
> ----------------------------------------
>
>                 Key: THRIFT-4140
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4140
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.10.0
>            Reporter: Adriaan Schmidt
>            Assignee: James E. King, III
>            Priority: Minor
>             Fix For: 0.11.0
>
>         Attachments: THRIFT-4140.patch
>
>
> Method *THttpServer::getTimeRFC1123()* (in lib/cpp/src/thr8ft/transport/THttpServer.cpp)
uses gmtime().
> This function is documented to be not thread-safe (https://www.gnu.org/software/libc/manual/html_node/Broken_002ddown-Time.html).
> Instead, we should use gmtime_r().



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message