thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-4138) Fix remaining undefined behavior invalid vptr casts in C++ library
Date Sat, 01 Apr 2017 14:21:41 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952243#comment-15952243
] 

ASF GitHub Bot commented on THRIFT-4138:
----------------------------------------

Github user jbapple-cloudera commented on the issue:

    https://github.com/apache/thrift/pull/1232
  
    UBSan refuses to report an error more than once, and unfortunately it does not have a
way to override this behavior. So, once you've seen one UBSan error at a particular line in
a particular function, it won't report it again until the binary exits.
    
    I agree that we are not using boost::filesystem::path. This was a different error from
https://github.com/boostorg/lexical_cast/blob/boost-1.54.0/include/boost/lexical_cast.hpp#L1620.


> Fix remaining undefined behavior invalid vptr casts in C++ library
> ------------------------------------------------------------------
>
>                 Key: THRIFT-4138
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4138
>             Project: Thrift
>          Issue Type: Sub-task
>          Components: C++ - Library
>            Reporter: Jens Geyer
>            Assignee: Jim Apple
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message