thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-4138) Fix remaining undefined behavior invalid vptr casts in C++ library
Date Sat, 01 Apr 2017 12:52:41 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952207#comment-15952207
] 

ASF GitHub Bot commented on THRIFT-4138:
----------------------------------------

GitHub user jbapple-cloudera opened a pull request:

    https://github.com/apache/thrift/pull/1232

    THRIFT-4138: Remove undefined behavior imported from Boost

    Client: C++
    
    There is undefined behavior in boost::lexical_cast that was fixed in
    https://github.com/boostorg/lexical_cast/issues/21, but that fix is
    only available in recent Boost releases. This patch removes all uses
    of lexical_cast instead.
    
    That removes the last undefined behavior, so this patch also makes
    ubsan.sh unconditionally fail on undefined behavior.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jbapple-cloudera/thrift boost-vptr

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1232.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1232
    
----
commit e8c76d1939ec0f338d4a520ec9e81cfefe6e33b1
Author: Jim Apple <jbapple-impala@apache.org>
Date:   2017-03-30T03:39:36Z

    THRIFT-4138: Remove undefined behavior imported from Boost
    Client: C++
    
    There is undefined behavior in boost::lexical_cast that was fixed in
    https://github.com/boostorg/lexical_cast/issues/21, but that fix is
    only available in recent Boost releases. This patch removes all uses
    of lexical_cast instead.
    
    That removes the last undefined behavior, so this patch also makes
    ubsan.sh unconditionally fail on undefined behavior.

----


> Fix remaining undefined behavior invalid vptr casts in C++ library
> ------------------------------------------------------------------
>
>                 Key: THRIFT-4138
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4138
>             Project: Thrift
>          Issue Type: Sub-task
>          Components: C++ - Library
>            Reporter: Jens Geyer
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message