thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James E. King, III (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-3857) thrift js:node complier support an object as parameter not an instance of struct
Date Sat, 01 Apr 2017 14:32:41 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-3857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952247#comment-15952247
] 

James E. King, III commented on THRIFT-3857:
--------------------------------------------

Any node.js folks want to comment on this?  The CI builds passed but this needs to be reviewed
and approved by someone who uses the language regularly.

The PR checks in a binary libparse.a build which needs to be removed... ideally if this PR
could be fixed, squashed into a single commit and rebased against the current master it would
make it easier to merge if approved.

> thrift js:node complier support an object as parameter not an instance of struct
> --------------------------------------------------------------------------------
>
>                 Key: THRIFT-3857
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3857
>             Project: Thrift
>          Issue Type: New Feature
>          Components: Node.js - Compiler
>    Affects Versions: 0.9.3, 1.0
>            Reporter: jiangq
>
> use the tutorial.thrift,code like:
> {code:javascript}
> let param = {
>   op: ttypes.Operation.DIVIDE,
>   num1: 1,
>   num2: 0
> }
> let work = new ttypes.Work(param);
> client.calculate(1, work)
>   .then(function(message) {
> 	console.log('Whoa? You know how to divide by zero?');
>   })
>   .fail(function(err) {
>     console.log("InvalidOperation " + err);
>   });
> {code}
> can we support like these:
> {code:javascript}
> let work = {
>   op: ttypes.Operation.DIVIDE,
>   num1: 1,
>   num2: 0
> }
> client.calculate(1, work)
>   .then(function(message) {
> 	console.log('Whoa? You know how to divide by zero?');
>   })
>   .fail(function(err) {
>     console.log("InvalidOperation " + err);
>   });
> {code}
> If we can support this feature will be very convenient´╝î and I have read the 't_js_generator.cc'
file, find this feature is easy to support, can we add the support for this feature?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message