thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James E. King, III (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-3627) Missing basic code style consistency of JavaScript.
Date Sun, 02 Apr 2017 03:35:42 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-3627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952508#comment-15952508
] 

James E. King, III commented on THRIFT-3627:
--------------------------------------------

This pull request probably needs to be rebased on upstream/master and resubmitted to merge
properly given its age.

> Missing basic code style consistency of JavaScript.
> ---------------------------------------------------
>
>                 Key: THRIFT-3627
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3627
>             Project: Thrift
>          Issue Type: Improvement
>          Components: JavaScript - Library
>            Reporter: Kazuki Matsuda
>            Priority: Minor
>
> E.g.)
> * No white space in {code}function(args){// beteween `){`{code}
> https://github.com/apache/thrift/blob/84cf363eeedf4cc9bb618bb2b1980696b9f6fc9b/lib/js/src/thrift.js#L1497
> * "Double quoted" (not 'single quoted') string litteral
> https://github.com/apache/thrift/blob/84cf363eeedf4cc9bb618bb2b1980696b9f6fc9b/lib/js/src/thrift.js#L133
> Those errors can be easily fixed by fixjsstyle.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message