thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (THRIFT-3607) Unify exception handling policy of TProcessor
Date Thu, 06 Apr 2017 12:58:42 GMT


ASF GitHub Bot commented on THRIFT-3607:

Github user jeking3 commented on the issue:
    This is related to THRIFT-3607.

> Unify exception handling policy of TProcessor
> ---------------------------------------------
>                 Key: THRIFT-3607
>                 URL:
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Wish List
>            Reporter: Aki Sukegawa
> A discussion in THRIFT-1805 uncovered inconsistent error handling behaviors of TProcessors
across languages and releases.
> Most outstanding are Java sync and async processors as described there, but others are
also subtly different in details.
> I propose unifying the TProcessor behavior by specifying mappings from "uncaught server
handler exceptions" to "observable server behaviors" as follows:
> * TApplicationException -> send TApplicationException with the message and the type
as thrown
> * TTransportException -> the connection is either already broken or newly broken
> * other exceptions -> send opaque TApplicationException(INTERNAL_ERROR)
> That way users can still arbitrarily disconnect  the client by throwing TTransportException.
> (IMO ideally this should have been done by exposing "client context" object to the handler
> The first one can be a bit controversial as it can be regarded as information leak.
> Also some may prefer unifying the TProcessor behavior to catch-all, so that servers never
die on handler exceptions.

This message was sent by Atlassian JIRA

View raw message