thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-3539) Use self.process_* instead of Processor.process_* in generated processor code
Date Thu, 06 Apr 2017 21:56:41 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-3539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15959839#comment-15959839
] 

ASF GitHub Bot commented on THRIFT-3539:
----------------------------------------

Github user jeking3 commented on the issue:

    https://github.com/apache/thrift/pull/1242
  
    Closed - fix didn't work.


> Use self.process_* instead of Processor.process_* in generated processor code
> -----------------------------------------------------------------------------
>
>                 Key: THRIFT-3539
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3539
>             Project: Thrift
>          Issue Type: Bug
>          Components: Python - Library
>            Reporter: Thomas Bartelmess
>            Assignee: James E. King, III
>
> In our codebase we ended up overriding the process_* handlers because we had some special
requirements, how exceptions are handled.
> in the __init__ function of processor the self._processMap refers to all the process_*
functions on the Processor class.
> {code}
> def __init__(self):
>   self._processMap = {}
>   self._processMap = Processor.process_foo
> {code}
> The processor should refer to the functions using self, so when they are overridden in
the subclass, the subclass implementation is used.
> {code}
> def __init__(self):
>   self._processMap = {}
>   self._processMap = self.process_foo
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message