thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-3204) SimpleServer process loop missed handle some error
Date Sun, 02 Apr 2017 05:48:41 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952535#comment-15952535
] 

ASF GitHub Bot commented on THRIFT-3204:
----------------------------------------

Github user jeking3 commented on the issue:

    https://github.com/apache/thrift/pull/529
  
    @jfarrell Recommend we close this as won't fix.  It never passed and the original author's
github repository isn't around any more.


> SimpleServer process loop missed handle some error
> --------------------------------------------------
>
>                 Key: THRIFT-3204
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3204
>             Project: Thrift
>          Issue Type: Bug
>          Components: Go - Library
>    Affects Versions: 0.9.2
>            Reporter: Jing Wang
>            Assignee: Jing Wang
>              Labels: patch
>
> SimpleServer do not handle all errors returned by processor.
> When a error returned by processor.Process methods In SimpleServer's processRequests,
program will omit this error and log nothing to the programmer if this error is not thrift.TTransportException
type.
> If a Protocol error happens, the server will close the client connection and log nothing,

> This bug is cause by a wrong "else if" condition.  In the if esle condition, the inside
variable "err" will cover the scope of outside "err", and it will always be "nil", the "else
if" condition will never  reached



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message