thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jeking3 <...@git.apache.org>
Subject [GitHub] thrift issue #1228: THRIFT-3978: tighten up pthread mutex implementation, re...
Date Sat, 01 Apr 2017 15:00:27 GMT
Github user jeking3 commented on the issue:

    https://github.com/apache/thrift/pull/1228
  
    For anybody interested in reviewing this pull request, I pretty much followed the logic
that boost::mutex is using with one exception.  In cases where boost ignores an error condition
to avoid throwing in a destructor, I have instead preferred to abort the process.  My thought
process on this is that should mutex destruction return EBUSY or EINVAL, it is a design flaw
in the implementation using the Mutex class.  EBUSY means we tried to delete the mutex while
it was locked.  EINVAL means it may have been destroyed twice.  In either case, getting a
core is way more useful than silently letting the issue pass by in a release build.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message