thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-4126) Validate objects in php extension
Date Sun, 19 Mar 2017 18:23:42 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15931869#comment-15931869
] 

ASF GitHub Bot commented on THRIFT-4126:
----------------------------------------

GitHub user kufd opened a pull request:

    https://github.com/apache/thrift/pull/1215

    Thrift 4126

    Hello
    It is a pull request with required fields validation for php extension
    Here is jira issue https://issues.apache.org/jira/browse/THRIFT-4126

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kufd/thrift THRIFT-4126

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1215.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1215
    
----
commit 5f5df5f790508f9b8400d3c92d80c16b38546c18
Author: myroslav.kosinskyi <myroslav.kosinskyi@skelia.com.ua>
Date:   2016-05-23T08:16:12Z

    fix performance issue when try to deserialize big message with small read buffer size

commit 2bfce820efd6aa47ee12d91ff08fe310a753049a
Author: kufd <kosinski@ukr.net>
Date:   2016-06-16T18:41:22Z

    Merge remote-tracking branch 'upstream/master'

commit 13231f8190583ddcca410a4a3f961628754cbf5e
Author: kufd <kosinski@ukr.net>
Date:   2016-07-23T09:56:02Z

    Merge remote-tracking branch 'upstream/master'

commit f07e38cc911e01846c85480de4bd5eb2bc365092
Author: kufd <kosinski@ukr.net>
Date:   2017-03-13T17:17:34Z

    merge with upstream master

commit 9312aa8930bc26a100c46153f47c4860b1169753
Author: kufd <kosinski@ukr.net>
Date:   2017-03-19T17:48:50Z

    implement required fields validation in php extension

----


> Validate objects in php extension
> ---------------------------------
>
>                 Key: THRIFT-4126
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4126
>             Project: Thrift
>          Issue Type: Improvement
>            Reporter: Myroslav Kosinskyi
>            Assignee: Myroslav Kosinskyi
>            Priority: Minor
>
> Now there is  not validation if required fields are set when we use php extension to
serialize and deserialize thrift objects.
> So i have implemented this feature
> And i am going to create a pull request soon



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message