thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-4114) Space after '///' in doc comments
Date Mon, 27 Mar 2017 06:27:41 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15942720#comment-15942720
] 

ASF GitHub Bot commented on THRIFT-4114:
----------------------------------------

GitHub user sunchao opened a pull request:

    https://github.com/apache/thrift/pull/1224

    THRIFT-4114: Space after '///' in doc comments

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sunchao/thrift rust-doc-string

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1224.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1224
    
----
commit 026c82f83f19b19c1df8a4b4f260226510b8ae23
Author: Chao Sun <sunchao@apache.org>
Date:   2017-03-27T06:24:56Z

    THRIFT-4114: Space after '///' in doc comments

----


> Space after '///' in doc comments
> ---------------------------------
>
>                 Key: THRIFT-4114
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4114
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Rust - Compiler
>            Reporter: Chao Sun
>            Priority: Minor
>
> Currently the generated thrift code doesn't have space after the doc string comment {{///}}.
It's better to add that for better styling. We should simply need to modify https://github.com/apache/thrift/blob/master/compiler/cpp/src/thrift/generate/t_rs_generator.cc#L2834.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message