Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id DF370200C23 for ; Wed, 22 Feb 2017 18:52:04 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id DDE31160B62; Wed, 22 Feb 2017 17:52:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2DC6A160B49 for ; Wed, 22 Feb 2017 18:52:04 +0100 (CET) Received: (qmail 24405 invoked by uid 500); 22 Feb 2017 17:52:03 -0000 Mailing-List: contact dev-help@thrift.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@thrift.apache.org Delivered-To: mailing list dev@thrift.apache.org Received: (qmail 24394 invoked by uid 99); 22 Feb 2017 17:52:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Feb 2017 17:52:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id D8FDA18E169 for ; Wed, 22 Feb 2017 17:52:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -1.199 X-Spam-Level: X-Spam-Status: No, score=-1.199 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id mOn_lkGhY-Xt for ; Wed, 22 Feb 2017 17:52:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id A6DAC5F640 for ; Wed, 22 Feb 2017 17:52:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 86551E02F1 for ; Wed, 22 Feb 2017 17:51:44 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3ED6B2411B for ; Wed, 22 Feb 2017 17:51:44 +0000 (UTC) Date: Wed, 22 Feb 2017 17:51:44 +0000 (UTC) From: "James E. King, III (JIRA)" To: dev@thrift.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (THRIFT-3974) Using clang-3.8 and ThreadSanitizer on the concurrency_test claims bad PThread behavior MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 22 Feb 2017 17:52:05 -0000 [ https://issues.apache.org/jira/browse/THRIFT-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3974: --------------------------------------- Priority: Minor (was: Major) > Using clang-3.8 and ThreadSanitizer on the concurrency_test claims bad PThread behavior > --------------------------------------------------------------------------------------- > > Key: THRIFT-3974 > URL: https://issues.apache.org/jira/browse/THRIFT-3974 > Project: Thrift > Issue Type: Bug > Components: C++ - Library > Affects Versions: 0.9.3, 0.10.0 > Reporter: James E. King, III > Assignee: James E. King, III > Priority: Minor > > After using ThreadSanitizer to prove THRIFT-2755 is no longer present after THRIFT-3932 was completed, it looks like there are some issues in the PThreadThread class, specifically that the destructor calls a virtual method. ThreadSanitizer picks calls this out (many, many times). > The usage may be correct, but since we're not using C++11 we cannot seal the class (mark it with the final keyword) which would tell ThreadSanitizer nothing can inherit from the class, making that behavior safe. > Another way to deal with this is to move the join implementation to a non-virtual method and have both the dtor and join() call it. -- This message was sent by Atlassian JIRA (v6.3.15#6346)