Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id AA5E4200C20 for ; Sun, 19 Feb 2017 12:23:12 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id A8EA2160B65; Sun, 19 Feb 2017 11:23:12 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E8644160B58 for ; Sun, 19 Feb 2017 12:23:11 +0100 (CET) Received: (qmail 7884 invoked by uid 500); 19 Feb 2017 11:23:11 -0000 Mailing-List: contact dev-help@thrift.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@thrift.apache.org Delivered-To: mailing list dev@thrift.apache.org Received: (qmail 7873 invoked by uid 99); 19 Feb 2017 11:23:10 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 19 Feb 2017 11:23:10 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id B3DC3DFADC; Sun, 19 Feb 2017 11:23:10 +0000 (UTC) From: jeking3 To: dev@thrift.apache.org Reply-To: dev@thrift.apache.org References: In-Reply-To: Subject: [GitHub] thrift pull request #1197: THRIFT-4084: Add a SSL/TLS negotiation check to c... Content-Type: text/plain Message-Id: <20170219112310.B3DC3DFADC@git1-us-west.apache.org> Date: Sun, 19 Feb 2017 11:23:10 +0000 (UTC) archived-at: Sun, 19 Feb 2017 11:23:12 -0000 Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1197#discussion_r101914893 --- Diff: lib/py/src/transport/sslcompat.py --- @@ -66,6 +66,14 @@ def legacy_validate_callback(cert, hostname): --- End diff -- I backed out my changes to lib/py and will re-test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---