thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jeking3 <...@git.apache.org>
Subject [GitHub] thrift pull request #1196: THRIFT-3891 TNonblockingServer configured with mo...
Date Sat, 18 Feb 2017 20:16:48 GMT
GitHub user jeking3 opened a pull request:

    https://github.com/apache/thrift/pull/1196

    THRIFT-3891 TNonblockingServer configured with more than one IO threads does not always
return from serve() upon stop()

    I took the comments from @nsuke and applied them to the PR.  I was able to reasonably
eliminate the boolean you mentioned however I could not go back to loopbreak.  I see no reasonable
way to synchronize here.  The run() thread will eventually need to release a mutex and THEN
call the event loop.  There's no way inside breakLoop() to know if it is actually IN the event
loop.  Given this, the exit variant is the only safe method to break the loop.
    
    The obsoletes PR #1080.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jeking3/thrift THRIFT-3891

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1196.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1196
    
----
commit 38d3c87aa11f1f4232cb97b01200c01fc578cd9d
Author: Bu─čra Gedik <bgedik@gmail.com>
Date:   2016-09-04T08:18:15Z

    THRIFT-3891 TNonblockingServer configured with more than one IO threads does not always
return from serve() upon stop()

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message