thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James E. King, III (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (THRIFT-4073) enum files are still being generated with unused imports
Date Thu, 09 Feb 2017 15:05:42 GMT

     [ https://issues.apache.org/jira/browse/THRIFT-4073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

James E. King, III resolved THRIFT-4073.
----------------------------------------
       Resolution: Fixed
         Assignee: James E. King, III
    Fix Version/s: 0.11.0

Passed CI, merged, thanks!

> enum files are still being generated with unused imports
> --------------------------------------------------------
>
>                 Key: THRIFT-4073
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4073
>             Project: Thrift
>          Issue Type: Bug
>          Components: Java - Compiler
>    Affects Versions: 0.10.0
>            Reporter: Christopher Tubbs
>            Assignee: James E. King, III
>             Fix For: 0.11.0
>
>
> I love that import statements are no longer being generated, because it means less "unused
imports" warnings from my compiler and checkstyle rules.
> However, it appears that the enum generation did not get as much care as class file generation.
There still remain some import statements in enum files. All of them are unused because of
the fully-qualified types being used instead, so they are safe to delete.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message